Simple pppoe + vlan setup issue

Hi ,

Im trying to setup a simple pppoe + vlan install and its not working . The pppoe appears to go up / down and its not getting any IP .... I have searched the forum and pretty much tried all proposed solution but its not working . Im guessing at this point its something very obvious and im not seeing it

Any help appreciated

Thanks

root@srx210> show pppoe interfaces
pp0.0 Index 71
State: Session up, Session ID: 5661,
Service name: None,
Session AC name: STESPQ3502W, Configured AC name: None,
Remote MAC address: <removed from posting> ,
Session uptime: 00:00:20 ago,
Auto-reconnect timeout: 10 seconds, Idle timeout: Never,
Underlying interface: ge-0/0/0.0 Index 70
Ignore End-of-List tag: Disable

Then a minute later :

root@srx210> show pppoe interfaces
pp0.0 Index 71
State: Down, Session ID: None,
Service name: None,
Session AC name: None, Configured AC name: None,
Remote MAC address: 00:00:00:00:00:00,
Auto-reconnect timeout: 10 seconds, Idle timeout: Never,
Underlying interface: ge-0/0/0.0 Index 70
Ignore End-of-List tag: Disable

Snippet of config ( see attached for the full one )

interfaces {
    ge-0/0/0 {
        vlan-tagging;
        unit 0 {
            encapsulation ppp-over-ether;
            vlan-id 35;
        }

pp0 {
unit 0 {
apply-macro pppoe;
ppp-options {
pap {
local-name <hidden>;
local-password "password"; ## SECRET-DATA
passive;
}
}
pppoe-options {
underlying-interface ge-0/0/0.0;
auto-reconnect 10;
client;
idle-timeout 0;
}
family inet {
negotiate-address;
}